New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: compare locales with suffix as case-insensitive #654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 3 3
Lines 122 122
Branches 32 32
=======================================
Hits 121 121
Misses 1 1 Continue to review full report at Codecov.
|
Related issue: Tokyo-Metro-Gov/covid19#2765 |
Co-Authored-By: Rafał Chłodnicki <rchl2k@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for matching case-insensitively in unit.test.js
.
Co-Authored-By: Rafał Chłodnicki <rchl2k@gmail.com>
I'll take over in few hours when I have free time |
Thank you @rchl, it helps us fight against COVID-19 in Japan but we are having multilingual, multinational and multicultural neighbors. I would like to meet up with you when we can overcome this panic situation around the globe! Thanks again |
Resolved with e614e8e |
Thank you very much! |
Hi @rchl, Do you mind being added to our Contributors' List? |
I don't mind. Go ahead. :) |
Comparison of locale codes in complete fashion i.e. ISO-631 Language Code and ISO-3166 Country / Region Code concatenated with a hyphen in between needs to be done as case-insensitive.
Not only have many web developers but also we ourselves been figured out that they used to use "complete" language codes in entirely lower case letters like zh-cn, zh-tw etc.