fix: initial redirect breaks reactivity in static mode #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
force-pushed
the
fix/redirect-generate
branch
from
6e02b34
to
761bcfe
Compare
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 3 3
Lines 129 129
Branches 35 35
=======================================
Hits 127 127
Misses 2 2 Continue to review full report at Codecov.
|
rchl
force-pushed
the
fix/redirect-generate
branch
from
761bcfe
to
b2f1f04
Compare
When we've detected browser language and need to redirect we need to do it from the middleware for the page to transition correctly. The problem is Nuxt doesn't trigger middleware for initial navigation in static mode (the idea is that it already ran when generating page on the server), so we can't do it properly. Fixed by hooking into the VueRouter "beforeEach" navigation hook so that we can handle it from the right place. Still, as Nuxt doesn't know that we are redirecting, it would throw some errors trying to load previous page. So use "location.assign()" to "hard" redirect. Resolves #737
rchl
force-pushed
the
fix/redirect-generate
branch
from
42611ff
to
ef80b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we've detected browser language and need to redirect we need to do
it from the middleware for the page to transition correctly. The problem
is Nuxt doesn't trigger middleware for initial navigation in static
mode (the idea is that it already ran when generating page on the server),
so we can't do it properly.
Fixed by hooking into the VueRouter "beforeEach" navigation hook so that
we can handle it from the right place. Still, as Nuxt doesn't know that
we are redirecting, it would throw some errors trying to load previous
page. So use "location.assign()" to "hard" redirect.
Resolves #737