Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only prerender for static target #75

Merged
merged 6 commits into from
Nov 9, 2022
Merged

fix: only prerender for static target #75

merged 6 commits into from
Nov 9, 2022

Conversation

dargmuesli
Copy link
Contributor

@dargmuesli dargmuesli commented Nov 1, 2022

Currently, the /robots.txt route is prerendered even for server deployments. A demo for that behavior can be observed in the first commit of this PR which adds a test that currently fails.

Closes #76.

src/module.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #75 (bc66236) into main (0cdf4ee) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   98.38%   98.43%   +0.05%     
==========================================
  Files           1        1              
  Lines          62       64       +2     
  Branches        9       10       +1     
==========================================
+ Hits           61       63       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/module.ts 98.43% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ricardogobbosouza ricardogobbosouza merged commit e1102d6 into nuxt-modules:main Nov 9, 2022
@dargmuesli dargmuesli deleted the fix/prerender branch November 9, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: route is prerendered even for ssr build
2 participants