-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support visual editing #949
Conversation
✅ Deploy Preview for nuxt-sanity-module ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2a2ae8c
to
20d4ca9
Compare
04647e2
to
7411043
Compare
Looks like the type tests are failing, the generated Potentially relevant issue: nuxt/nuxt#20379 |
f45d1fe
to
428b94a
Compare
41d267f
to
cb3cac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great! Thank you so much for the phenomenal work here.
Sorry to have just pushed changes - mostly a result of my lack of time.
If you have a chance to review, would you see if I've unwittingly undone something you set for a good reason? 🙏
refs #934 |
2f50329
to
dbd3f88
Compare
Think this is good to go pending documentation. |
✅ Live Preview ready!
|
Some minimal docs are up, I figured best to get this shipped and adjust and improve those accordingly. Let me know if you'd like them structured differently. Also snuck in a few last minute changes to the configuration based on some internal conversations. Ready for a final review! (Can I leave merge/release up to you @danielroe?) |
Perfect! |
Hey all, I'm super excited about this feature, when will there be a release to NPM in which I can use visual editing? |
There's a beta release at |
You probably need to include it. But you will find a rabbit hole down there. If you get a chance and get something working, do let me know. One main issue is that in order for optimising deps with One avenue to explore is that this is not an issue in the module repository which suggests that something about the config (maybe another package being installed?) avoids the issue. But I need to make some time to investigate. |
The deeper I dive, the weirder it gets! I try this to see if i can get any further: https://www.sanity.io/docs/nuxt-loader |
@timbenniks Best not to go down the |
Released! Please do let me know if you encounter any niggles. 🙏 |
Im not familiar with the issue you are encountering, but this may help you get started |
This PR provides a method for implementing Sanity visual editing in Nuxt applications.
Current Progress
useSanityQuery
and CSMuseAsyncData
andclient.fetch