Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support reading cms/sanity.config.ts #977

Merged
merged 2 commits into from
Mar 28, 2024
Merged

feat: support reading cms/sanity.config.ts #977

merged 2 commits into from
Mar 28, 2024

Conversation

danielroe
Copy link
Collaborator

This does several things:

  1. by default it looks for a ~~/cms/sanity.config.* file relative to your project's root directory.
  2. it supports explicitly configuring this path with the configFile property
  3. if the path is within the nuxt project nuxt will automatically reload if the file is edited

It does fall back to the previous behaviour (looking for a sanity.json in your root directory) if there is no such file.

@danielroe danielroe added the enhancement New feature or request label Mar 25, 2024
@danielroe danielroe self-assigned this Mar 25, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 25, 2024 •
edited

✅ Deploy Preview for nuxt-sanity-module canceled.

Name Link
🔨 Latest commit 8fa3337
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-sanity-module/deploys/66058a312075540008786f83

@danielroe danielroe requested a review from rdunk March 25, 2024 22:30
rdunk
rdunk reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@rdunk rdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, but LGTM!

src/module.ts Outdated Show resolved Hide resolved
rdunk
rdunk approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@rdunk rdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danielroe danielroe merged commit a5148fb into main Mar 28, 2024
5 checks passed
@danielroe danielroe deleted the feat/new-sanity-config branch March 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdunk rdunk rdunk approved these changes

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @rdunk