fix: parse-headers, debug and async-cache-dedupe no longer need to be optimized
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be optimized
✅ Deploy Preview for nuxt-sanity-module canceled.
|
danielroe
approved these changes
Apr 25, 2024
|
(I don't think we are inlining |
danielroe
deleted the
remove-parse-headers-debug-and-async-cache-dedupe-from-optimizeDeps
branch
|
@danielroe oops, I didn't mean inline, but optimize: Line 323 in 193fa68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
get-itv8.4.24 we started inliningparse-headersanddebugas it were causing issues with the latest version ofhydrogen.The same is true for
@sanity/core-loaderv1.6.7 andasync-cache-dedupe.What's the reason for inlining
@sanity/clientbtw? It should be strictly ESM compatible in its latest version 🤔