Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config MultiSitemapsInput types #217

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

reslear
Copy link
Contributor

@reslear reslear commented Jan 19, 2024

fix config MultiSitemapsInput types:

 Property 'index' is incompatible with index signature.
      Type '{ sitemap: string; }[]' has no properties in common with type 'Partial<SitemapDefinition>'.ts(2322)

@reslear reslear changed the title fix: MultiSitemapsInput config typo fix: config MultiSitemapsInput types Jan 19, 2024
@harlan-zw
Copy link
Collaborator

Thanks! Does this actually fix it though 🤔 seems like it wouldn't change the types (in theory)

@reslear
Copy link
Contributor Author

reslear commented Jan 19, 2024

typescript baby :) but i use this fix as a patch, works good :)

@harlan-zw
Copy link
Collaborator

Good enough for me 😅

@harlan-zw harlan-zw merged commit 9b52cd9 into nuxt-modules:main Jan 19, 2024
1 check passed
@reslear reslear deleted the patch-1 branch January 19, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants