Merge pull request #32 from nuxt-community/fix/localization-escape

Fix/localization escape

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest]
-        node: [12]
+        node: [14]
 
     steps:
       - uses: actions/setup-node@v2

example/cypress/integration/features.js

@@ -2,15 +2,14 @@
 
 describe("Snipcart", () => {
   it("snipcart element should have been injected", () => {
-    cy.visit("/");
-    cy.server()
-    cy.route({
+    cy.intercept({
       method: "GET",
-      url: "https://cdn.snipcart.com/**"
+      url: "https://app.snipcart.com/api/sessions"
     }).as("apiCheck");
 
-    cy.wait('@apiCheck')
-    cy.wait(1000)
+    cy.visit("/");
+
+    cy.wait("@apiCheck");
 
     cy.get('[data-item-custom1-name="Frame color"]').should('exist')
     cy.get('[data-item-custom5-name="Readonly information"]').should('exist')

example/cypress/integration/injection.js

@@ -2,8 +2,28 @@
 
 describe('Snipcart', () => {
   it('snipcart element should have been injected', () => {
+    cy.intercept({
+      method: "GET",
+      url: "https://app.snipcart.com/api/sessions"
+    }).as("apiCheck");
+
+    cy.intercept({
+      method: "GET",
+      url: "https://cdn.snipcart.com/themes/*/default/snipcart.js"
+    }).as("jsCheck");
+
+    cy.intercept({
+      method: "GET",
+      url: "https://cdn.snipcart.com/themes/*/default/snipcart.css"
+    }).as("cssCheck");
+
     cy.visit('/')
 
+    cy.wait("@apiCheck");
+    cy.wait("@jsCheck");
+    cy.wait("@cssCheck");
+
+
     cy.get('html').then((el) => {
       const html = el[0].innerHTML
 
@@ -26,8 +46,6 @@ describe('Snipcart', () => {
       );
     })
 
-    cy.wait(1000)
-
     cy.get('html').then((el) => {
       const html = el[0].innerHTML;
 

example/cypress/integration/locales.js

@@ -2,27 +2,26 @@
 
 describe("Snipcart", () => {
   it("snipcart element should have been injected", () => {
-    cy.visit("/");
-    cy.server();
-    cy.route({
+    cy.intercept({
       method: "GET",
-      url: "https://cdn.snipcart.com/**"
+      url: "https://app.snipcart.com/api/sessions"
     }).as("apiCheck");
 
+    cy.visit("/");
+
     cy.wait("@apiCheck");
-    cy.wait(1000)
 
     cy.get(".snipcart-add-item").trigger("click");
 
-    cy.get(".snipcart-modal__container").should("contain", "Total fr");
+    cy.get(".snipcart-modal__container").should("contain", "We're Total fr");
 
     cy.get(".snipcart-modal__close-title").trigger('click');
 
     cy.get(".switch-lang").trigger('click');
 
     cy.get(".snipcart-checkout").trigger('click');
 
-    cy.get(".snipcart-modal__container").should("contain", "Total en");
+    cy.get(".snipcart-modal__container").should("contain", "We're Total en");
 
   });
 });

example/nuxt.config.js

@@ -11,12 +11,12 @@ export default {
     locales: {
       fr: {
         cart_summary: {
-          total: 'Total fr'
+          total: 'We\'re Total fr'
         }
       },
       en: {
         cart_summary: {
-          total: 'Total en'
+          total: "We're Total en"
         }
       }
     },

lib/module.js

@@ -76,6 +76,10 @@ module.exports = function (moduleOptions) {
     }
   )
 
+  let str = JSON.stringify(options.locales)
+  str = str.replace(/'/g, "\\\\'")
+  options.locales = JSON.parse(str)
+
   this.addPlugin({
     src: path.resolve(__dirname, 'plugin.js'),
     options

package.json

@@ -20,7 +20,8 @@
     "lint": "eslint --ext .js,.vue .",
     "release": "yarn test && standard-version && git push --follow-tags && npm publish",
     "test": "yarn lint && yarn test:e2e",
-    "test:e2e": "cd example && yarn cypress:run"
+    "test:e2e": "cd example && yarn cypress:run",
+    "cypress:open": "cd example && yarn open"
   },
   "devDependencies": {
     "@babel/core": "latest",
@@ -31,7 +32,7 @@
     "@nuxtjs/module-test-utils": "latest",
     "babel-eslint": "latest",
     "chai": "latest",
-    "cypress": "^7.1.0",
+    "cypress": "^8.6.0",
     "eslint": "latest",
     "husky": "latest",
     "nuxt": "latest",