Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify app.html file if no changes occur #87

Closed
AndrewBogdanovTSS opened this issue Sep 9, 2019 · 5 comments
Closed

Do not modify app.html file if no changes occur #87

AndrewBogdanovTSS opened this issue Sep 9, 2019 · 5 comments

Comments

@AndrewBogdanovTSS
Copy link

app.html is modified by every run of nuxt command even though no icons are changed in the resources. This is very irritating since file is not a gitignore list and it always needs to be reverted before the commit

@farnabaz
Copy link
Collaborator

farnabaz commented Sep 9, 2019

I don't understand, the module does not change app.html in any case.
Could you create a simple project to reproduce this issue?

@AndrewBogdanovTSS
Copy link
Author

@farnabaz it modifies line endings. Have you tried in on Windows? I will try to prepare a test project

@AndrewBogdanovTSS
Copy link
Author

That's what I get after every run of the project in the dev mode
https://take.ms/1fbJ4
https://take.ms/1lKw4

@farnabaz
Copy link
Collaborator

farnabaz commented Sep 11, 2019

I believe this isn't related to svg-sprite-module. It is sound like your IDE modifies line endings.

I've checked module in windows, but nothing happened after running nuxt command

@AndrewBogdanovTSS
Copy link
Author

No, it happens even if I run my project outside of any IDE. Change is tracked by Git. It also can be proved by looking in the terminal, where ✔ success SVG sprite injected message appear every time, even if no modifications to icons has been applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants