Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call tailwindcss:config hook after all modules are initialised #826

Closed
danielroe opened this issue Mar 21, 2024 · 1 comment · Fixed by #818
Closed

call tailwindcss:config hook after all modules are initialised #826

danielroe opened this issue Mar 21, 2024 · 1 comment · Fixed by #818
Assignees
Labels
enhancement New feature or request

Comments

@danielroe
Copy link
Contributor

At the moment, tailwindcss:config is called synchronously when this module runs, meaning other modules which hope to use tailwindcss or modify its configuration must be registered before it.

However, dependencies between modules aren't ideal. Instead, we should register a hook in modules:done that finally calls tailwindcss:config. Alternatively, we could also call tailwindcss:config directly in getContents of a template.

@ineshbose
Copy link
Collaborator

I'm looking to address this in #818 as that is a complete rewrite of loading the config. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants