Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nuxt-scripts integration #306

Merged
merged 40 commits into from
Jun 28, 2024

Conversation

huang-julien
Copy link
Contributor

@huang-julien huang-julien commented Apr 8, 2024

Hi 👋

This PR implements @nuxt/scripts and force the constraint to nuxt 3 as there probably won't be any additionnal fixes for nuxt 2 (and it's reaching EOL)

Copy link
Contributor Author

@huang-julien huang-julien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why 'to wait for error logs' is failing. I can't retireve any log.

package.json Outdated Show resolved Hide resolved
src/module.ts Outdated Show resolved Hide resolved
@huang-julien huang-julien marked this pull request as draft April 14, 2024 13:28
test/e2e.test.ts Fixed Show fixed Hide fixed
@harlan-zw harlan-zw mentioned this pull request Apr 29, 2024
50 tasks
@nuxt-modules nuxt-modules deleted a comment from huang-julien May 6, 2024
@nuxt-modules nuxt-modules deleted a comment from huang-julien May 6, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 32.87671% with 49 lines in your changes missing coverage. Please review.

Project coverage is 29.41%. Comparing base (dc164cc) to head (838a7ab).
Report is 42 commits behind head on main.

Current head 838a7ab differs from pull request most recent head b9ac0d7

Please upload reports for the commit b9ac0d7 to get more accurate results.

Files Patch % Lines
src/runtime/components/NuxtTurnstile.vue 0.00% 24 Missing ⚠️
src/runtime/composables/turnstile.ts 0.00% 21 Missing ⚠️
src/module.ts 85.71% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #306       +/-   ##
===========================================
+ Coverage   19.26%   29.41%   +10.14%     
===========================================
  Files          12       10        -2     
  Lines         493      374      -119     
  Branches       23       21        -2     
===========================================
+ Hits           95      110       +15     
+ Misses        398      264      -134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@huang-julien huang-julien marked this pull request as ready for review June 21, 2024 19:37
Copy link
Collaborator

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you people for the collaboration!

@dargmuesli dargmuesli merged commit 44cb64c into nuxt-modules:main Jun 28, 2024
3 checks passed
dargmuesli-bot pushed a commit that referenced this pull request Jun 28, 2024
## [0.9.0](v0.8.0...v0.9.0) (2024-06-28)

### Features

* nuxt-scripts integration ([#306](#306)) ([44cb64c](44cb64c))
@dargmuesli-bot
Copy link
Collaborator

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants