Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy integrations import #712

Closed
Tahul opened this issue Dec 7, 2022 · 1 comment
Closed

Legacy integrations import #712

Tahul opened this issue Dec 7, 2022 · 1 comment

Comments

@Tahul
Copy link
Contributor

Tahul commented Dec 7, 2022

Old GitHub integration usually on /releases or /changelog page is currently broken.

The nuxtlabs/github-module still works, and still is compatible with Docus.

We just need to take a decision about this module and how we should orchestrate this integration.

I have two questions about this:

  • If we provide integrations that can be used from multiple themes, should we do it from Elements? (cc @Atinux)
  • What is the best way to detect the presence of a module in Nuxt 3? (cc @danielroe)
    • at runtime?
    • inside another module?
This was referenced Dec 7, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
@Atinux Volta.net
Copy link
Contributor

Atinux commented Dec 7, 2022

I believe best would be to integrate GitHub with Elements directly.

@Tahul Tahul closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Atinux @Tahul