Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global styles #9

Closed
atinux opened this issue Nov 7, 2022 — with Volta.net · 5 comments · Fixed by #11
Closed

Global styles #9

atinux opened this issue Nov 7, 2022 — with Volta.net · 5 comments · Fixed by #11
Labels
enhancement New feature or request

Comments

Copy link
Contributor

atinux commented Nov 7, 2022

It would be nice to support light and dark by default, as well as adding anti aliasing too.

WDYT @bdrtsky @Tahul ?

@atinux atinux added the enhancement New feature or request label Nov 7, 2022 — with Volta.net
Copy link
Contributor

bdrtsky commented Nov 7, 2022

If you mean global styles, then I believe background color shouldn't be in this repo. Having color mode tokens split between two codebases feels wrong. You suggest to put body text color here, and body background color elsewhere?

As for Prose, then we already have dark/light variations there, isn't it? Most of it actually just inherited from body styles, or whatever you have on parent.

Copy link
Contributor Author

atinux commented Nov 7, 2022

I am thinking about the text color and background color for code for example that could be set.

Checkout the dark mode on https://content-wind-git-feat-prose-atinux.vercel.app/

PR: atinux/content-wind#34

Copy link
Contributor

bdrtsky commented Nov 8, 2022

Code will be handled by Shiki theme

Copy link
Contributor Author

atinux commented Nov 8, 2022

Then what about antialiasing and default text color?

Copy link
Contributor

Tahul commented Nov 8, 2022

I think it is obvious we need to ship a global stylesheet (.css) with that prose.

What are the styles we are limiting ourselves to there?

I would try to keep it as "minimal" as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants