Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove lodash #20

Closed
wants to merge 1 commit into from
Closed

fix: Remove lodash #20

wants to merge 1 commit into from

Conversation

timneutkens
Copy link

There is no need to pull in all of lodash (1.1MB install size) for just 1 function.

I'm creating a companion PR to remove it from webpackbar too 馃憤

@timneutkens
fix: Remove lodash
9855a2b 
There is no need to pull in all of lodash (1.1MB install size) for just 1 function.
@timneutkens timneutkens mentioned this pull request Aug 26, 2018
Closed
@pi0
Copy link
Member

pi0 commented Aug 28, 2018

Hi & thanks. But several versions are required by dependencies including table. But as consola should be as small as possible, we can inline startcase into bundle

@pi0 pi0 closed this in 2cec678 Oct 5, 2018
@pi0
Copy link
Member

pi0 commented Oct 5, 2018

Thanks, @timneutkens again for this PR. I've removed the dependency of lodash. Will try to do the same for webpackbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timneutkens @pi0