Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better typescript typings #327

Merged
merged 5 commits into from
Aug 5, 2020
Merged

feat: better typescript typings #327

merged 5 commits into from
Aug 5, 2020

Conversation

mathe42
Copy link
Contributor

@mathe42 mathe42 commented Aug 2, 2020 •
edited
Loading

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Better typings.

This PR includes:

  1. adding typings for docs-theme
  2. changes to content types
  3. adding typings for config for content

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

No need for tests this is only a change in typings

@mathe42 mathe42 changed the title Feat/typescript/better typing feat: better typescript Aug 2, 2020
@mathe42 mathe42 changed the title feat: better typescript feat: better typescript typings Aug 2, 2020
@Atinux
Copy link
Member

Atinux commented Aug 4, 2020

Do you mind fixing the conflicts so we can merge it? :)

@mathe42
Copy link
Contributor Author

mathe42 commented Aug 5, 2020

@benjamincanac @Atinux merged and fixed a bug.

@benjamincanac benjamincanac merged commit 8d9f47c into nuxt:dev Aug 5, 2020
@nogic1008 nogic1008 mentioned this pull request Aug 25, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

@Atinux Atinux Atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathe42 @Atinux @benjamincanac