Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix links #2267

Merged
merged 31 commits into from Sep 15, 2023
Merged

docs: fix links #2267

merged 31 commits into from Sep 15, 2023

Conversation

nobkd
Copy link
Contributor

@nobkd nobkd commented Aug 30, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixing and updating links.

There are still some TODOs where I'm unsure or don't know how to fix a link.
Help is very welcome.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 30, 2023

βœ… Deploy Preview for nuxt-content ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 46543a1
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/650183d5c175800008b91b32
😎 Deploy Preview https://deploy-preview-2267--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nuxt-studio
Copy link

nuxt-studio bot commented Sep 2, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
studio-uxss-oo Edit on Studio β†—οΈŽ View Live Preview c7e34ae

@nobkd nobkd changed the title docs(v1): fix links docs: fix links Sep 2, 2023
@nobkd nobkd marked this pull request as ready for review September 11, 2023 22:34
nobkd and others added 17 commits September 12, 2023 21:35
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Co-authored-by: Farnabaz <farnabaz@gmail.com>
@nobkd
Copy link
Contributor Author

nobkd commented Sep 12, 2023

Thanks a lot!

I'll update the link for https://forestry.io to the redirect https://tina.io/forestry because it's unclear how long the domain will redirect correctly.

There are still a few more TODOs, but I'll check if I can resolve them myself.

@nobkd
Copy link
Contributor Author

nobkd commented Sep 12, 2023

Thank you for resolving almost all TODOs, @farnabaz ❀️

Just here https://github.com/nuxt/content/pull/2267/files#diff-9295ca16481aff5c4ae1e446c4ee7319bd6195c0a11dfd4a1147e34f1695bb8cR180 is a leftover TODO.

I'm not sure if it is a good idea to uncomment that part, as the new source is not that readable.
See: https://github.com/nuxt-modules/mdc/blob/main/src/runtime/parser/index.ts#L32-L51

@farnabaz
Copy link
Member

I think we can redirect users to options.ts which lists remark/rehype plugins.

@nobkd
Copy link
Contributor Author

nobkd commented Sep 13, 2023

That sounds good πŸ‘

@farnabaz farnabaz merged commit 5cc55ca into nuxt:main Sep 15, 2023
7 checks passed
@farnabaz
Copy link
Member

Thanks ❀️

@nobkd nobkd deleted the docs-v1/fix-links branch September 15, 2023 09:31
@farnabaz farnabaz mentioned this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants