Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ContentList): component slot typechecking #2277

Merged
merged 1 commit into from Sep 1, 2023

Conversation

cexbrayat
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The slot property is list and not data, so the current type is inaccurate and fails typechecking when used as:

<ContentList v-slot="{ list }">...</ContentList>

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

The slot property is `list` and not `data`, so the current type is inaccurate and fails typechecking when used as:

```vue
<ContentList v-slot="{ list }">...</ContentList>
```
@netlify
Copy link

netlify bot commented Sep 1, 2023

βœ… Deploy Preview for nuxt-content ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 6f519ab
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/64f1b5935525bf00070c09e8
😎 Deploy Preview https://deploy-preview-2277--nuxt-content.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@farnabaz farnabaz merged commit 467b757 into nuxt:main Sep 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants