fix: ensure bundler module resolution works with runtime type imports
#2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f492947
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b02e475c.nuxt-content-1il.pages.dev |
| Branch Preview URL: | https://fix-bundler-resolution.nuxt-content-1il.pages.dev |
danielroe
changed the title
bundler module resolution works with runtime type imports
danielroe
commented
Dec 19, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
farnabaz
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #2469
❓ Type of change
📚 Description
This adds support for Bundler TypeScript module resolution. It changes extensions of runtime dir files to
.jswhich should be safe as this is atype: moduleproject.I also add a subpath for
@nuxt/content/dist/runtime/typesas this is already documented. But we could also have a more ergonomic subpath for type augmentation.📝 Checklist