Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in showURL prop #2537

Merged
merged 3 commits into from Feb 6, 2024
Merged

typo in showURL prop #2537

merged 3 commits into from Feb 6, 2024

Conversation

mathieunicolas
Copy link
Contributor

Correct prop is "showURL" according to the listhen package : https://www.npmjs.com/package/listhen

Correct prop is "showURL"
Copy link

nuxt-studio bot commented Feb 4, 2024

Live Preview ready!

Name Edit Preview Latest Commit
Content Edit on Studio ↗︎ View Live Preview 9447183

@nobkd
Copy link
Contributor

nobkd commented Feb 4, 2024

There are more places with that in the docs:

Search: https://github.com/search?q=repo%3Anuxt%2Fcontent%20showURL&type=code

- Default: `{ ws: { port: 4000, showUrl: true } }`


And the default in the docs section is even wrong:

content/src/module.ts

Lines 325 to 332 in 5a9e7d9

watch: {
ws: {
port: {
port: 4000,
portRange: [4000, 4040]
},
hostname: 'localhost',
showURL: false

- Default: `{ ws: { port: 4000, showUrl: true } }`

showURL is false in the module code


Can you add changes for those please?

I would add them here by suggestion, but GitHub limits suggestions to the git change area.

Thank you

Please look over it yourself too, as i have just skimmed over it :)

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@farnabaz farnabaz merged commit d3b2d76 into nuxt:main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants