Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add style while generating local fallbacks for variable #110

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

qwerzl
Copy link
Collaborator

@qwerzl qwerzl commented Apr 1, 2024

I noticed this problem while testing. While adding local fallbacks for variable fonts, styles should also be added.

@qwerzl qwerzl requested a review from danielroe April 1, 2024 14:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@0913b4b). Click here to learn what that means.

Files Patch % Lines
src/css/parse.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage        ?   64.60%           
=======================================
  Files           ?       41           
  Lines           ?     2639           
  Branches        ?      425           
=======================================
  Hits            ?     1705           
  Misses          ?      909           
  Partials        ?       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe merged commit 913ee71 into nuxt:main Apr 1, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants