fix: use dev option to treeshake hmr code

nuxt · Nov 15, 2022 · 152cfe4 · 152cfe4
1 parent f7f0a95
commit 152cfe4
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/packages/nuxt/src/pages/page-meta.ts b/packages/nuxt/src/pages/page-meta.ts
@@ -19,19 +19,17 @@ export default __nuxt_page_meta
 `
 
 const CODE_HMR = `
-if (process.dev) {
-  // Vite
-  if (import.meta.hot) {
-    import.meta.hot.accept(mod => {
-      Object.assign(__nuxt_page_meta, mod)
-    })
-  }
-  // Webpack
-  if (import.meta.webpackHot) {
-    import.meta.webpackHot.accept((err) => {
-      if (err) { window.location = window.location.href }
-    })
-  }
+// Vite
+if (import.meta.hot) {
+  import.meta.hot.accept(mod => {
+    Object.assign(__nuxt_page_meta, mod)
+  })
+}
+// Webpack
+if (import.meta.webpackHot) {
+  import.meta.webpackHot.accept((err) => {
+    if (err) { window.location = window.location.href }
+  })
 }`
 
 export const PageMetaPlugin = createUnplugin((options: PageMetaPluginOptions) => {
@@ -109,7 +107,7 @@ export const PageMetaPlugin = createUnplugin((options: PageMetaPluginOptions) =>
       }
 
       if (!hasMacro && !code.includes('export { default }') && !code.includes('__nuxt_page_meta')) {
-        s.overwrite(0, code.length, CODE_EMPTY + CODE_HMR)
+        s.overwrite(0, code.length, CODE_EMPTY + (options.dev ? CODE_HMR : ''))
         return result()
       }
 
@@ -138,7 +136,7 @@ export const PageMetaPlugin = createUnplugin((options: PageMetaPluginOptions) =>
 
           const meta = node.arguments[0] as Expression & { start: number, end: number }
 
-          let contents = `const __nuxt_page_meta = ${code!.slice(meta.start, meta.end) || '{}'}\nexport default __nuxt_page_meta` + CODE_HMR
+          let contents = `const __nuxt_page_meta = ${code!.slice(meta.start, meta.end) || '{}'}\nexport default __nuxt_page_meta` + (options.dev ? CODE_HMR : '')
 
           function addImport (name: string | false) {
             if (name && importMap.has(name)) {
@@ -168,7 +166,7 @@ export const PageMetaPlugin = createUnplugin((options: PageMetaPluginOptions) =>
       })
 
       if (!s.hasChanged() && !code.includes('__nuxt_page_meta')) {
-        s.overwrite(0, code.length, CODE_EMPTY + CODE_HMR)
+        s.overwrite(0, code.length, CODE_EMPTY + (options.dev ? CODE_HMR : ''))
       }
 
       return result()