fix: use legacy commonjs transform plugin

nuxt · Jun 20, 2022 · 986264a · 986264a
1 parent be5d822
commit 986264a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/vite/src/server.ts b/packages/vite/src/server.ts
@@ -26,7 +26,7 @@ export async function buildServer (ctx: ViteBuildContext) {
     resolve: {
       alias: {
         '#build/plugins': resolve(ctx.nuxt.options.buildDir, 'plugins/server'),
-        ...ctx.nuxt.options.experimental.externalVue
+        ...ctx.nuxt.options.experimental.externalVue || ctx.nuxt.options.dev
           ? {}
           : {
               '@vue/reactivity': _resolve(`@vue/reactivity/dist/reactivity.cjs${ctx.nuxt.options.dev ? '' : '.prod'}.js`),
@@ -39,7 +39,9 @@ export async function buildServer (ctx: ViteBuildContext) {
       }
     },
     ssr: {
-      external: ctx.nuxt.options.experimental.externalVue ? ['#internal/nitro', '#internal/nitro/utils', 'vue', 'vue-router'] : ['#internal/nitro', '#internal/nitro/utils'],
+      external: ctx.nuxt.options.experimental.externalVue
+        ? ['#internal/nitro', '#internal/nitro/utils', 'vue', 'vue-router']
+        : ['#internal/nitro', '#internal/nitro/utils'],
       noExternal: [
         ...ctx.nuxt.options.build.transpile,
         // TODO: Use externality for production (rollup) build

diff --git a/packages/vite/src/vite.ts b/packages/vite/src/vite.ts
@@ -30,6 +30,9 @@ export async function bundle (nuxt: Nuxt) {
     nuxt,
     config: vite.mergeConfig(
       {
+        legacy: {
+          buildRollupPluginCommonjs: !nuxt.options.experimental.externalVue
+        },
         resolve: {
           alias: {
             ...nuxt.options.alias,

diff --git a/test/fixtures/basic/nuxt.config.ts b/test/fixtures/basic/nuxt.config.ts
@@ -28,8 +28,6 @@ export default defineNuxtConfig({
     }
   },
   experimental: {
-    // TODO: enable by default or work around the need for this
-    externalVue: true,
     reactivityTransform: true
   }
 })