This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(vite): improve external checks for dev-bundler #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
|
✔️ Deploy Preview for nuxt3-docs ready! 🔨 Explore the source changes: b5f7228 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/617bb2aa8f73860007c039dd 😎 Browse the preview: https://deploy-preview-1538--nuxt3-docs.netlify.app |
pi0
reviewed
Oct 28, 2021
pi0
reviewed
Oct 28, 2021
danielroe
commented
Oct 28, 2021
pi0
changed the title
pi0
reviewed
Oct 29, 2021
| @@ -41,7 +41,6 @@ export async function buildServer (ctx: ViteBuildContext) { | |||
| external: [], | |||
| noExternal: [ | |||
| ...ctx.nuxt.options.build.transpile, | |||
| /\.(es|esm|esm-browser|esm-bundler).js$/, | |||
There was a problem hiding this comment.
Since we are not using externality for prod build, I think would be a safe pattern to keep
There was a problem hiding this comment.
Agreed. Shall I follow up with a PR adding externality support for nitro?
There was a problem hiding this comment.
Suggested next steps:
- Support externality for vite's prod build
- Support externality for webpack external checks
- Support externality for nitro
There was a problem hiding this comment.
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Lots! For example nuxt/nuxt#12233
closes nuxt/nuxt#12632
❓ Type of change
📚 Description
With this PR we use an upgraded
externalityto try to detect (using new utility: unjs/mlly#16) whether an external is in fact valid to import within a node context.📝 Checklist