Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt3): extends support for app/router.options #3939

Merged
merged 4 commits into from
Apr 4, 2022
Merged

feat(nuxt3): extends support for app/router.options #3939

merged 4 commits into from
Apr 4, 2022

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented Mar 28, 2022 •
edited
Loading

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Following up nuxt/nuxt#13367 (extends support progress) this PR allows extending app/ directory (app/router.options) for extended config layers.

  • Extends support for app directory
  • Tests

ℹ️ Override behavior

It uses defu to merge router options if app/router.options exists for multiple layers

@kevinmarrec kevinmarrec requested a review from pi0 March 28, 2022 11:26
@netlify
Copy link

netlify bot commented Mar 28, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 41dc828
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/624aaa4677ad5900084a39fb

@pi0 pi0 mentioned this pull request Jan 19, 2023
Open
18 tasks
@kevinmarrec
Copy link
Contributor Author

Need to deal with the test-types not passing :)

@kevinmarrec
Copy link
Contributor Author

@pi0 I updated the code following suggestion to keep imports in generated file and merge theme here.
I added one question regarding an eventually trailing , in generation.

pi0
pi0 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 💚

@pi0 pi0 changed the title feat(nuxt3): extends support for app/ directory feat(nuxt3): extends support for app/router.options Apr 4, 2022
@pi0 pi0 merged commit dda0ceb into main Apr 4, 2022
@pi0 pi0 deleted the extends-app branch April 4, 2022 08:23
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinmarrec @pi0 @danielroe