Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): only reload for top level dirs #4912

Merged
merged 1 commit into from
May 13, 2022
Merged

fix(nuxi): only reload for top level dirs #4912

merged 1 commit into from
May 13, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 10, 2022 •
edited

🔗 Linked issue

resolves nuxt/nuxt#13946

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

At the moment the creation of any pages, composables or components directory will trigger a reload, even deeply nested.

This PR resolves them to ensure we're not needlessly reloading nuxt.

📝 Checklist

  • I have linked an issue or discussion.
  • test on windows
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working cli 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels May 10, 2022
@danielroe danielroe requested a review from pi0 May 10, 2022 11:33
@danielroe danielroe self-assigned this May 10, 2022
@netlify
Copy link

netlify bot commented May 10, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit fdbdb17
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/627a4d8d54c2590008fae40b

@pi0 pi0 changed the title fix(nuxi): only reload for resolved resolved reload dirs fix(nuxi): only reload for top level dirs May 13, 2022
@pi0 pi0 merged commit 2886dfd into main May 13, 2022
@pi0 pi0 deleted the fix/resolve-reload-dirs branch May 13, 2022 10:59
danielroe added a commit that referenced this pull request May 13, 2022
@danielroe
fix(nuxi): only reload for top level dirs (#4912)
fab8875
@pi0 pi0 mentioned this pull request Jun 10, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working cli 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating a pages directory from a module in a subdirectory makes vite compilation restart
2 participants
@danielroe @pi0