Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): respect baseurl when redirecting (and universal router) #4933

Merged
merged 2 commits into from
May 11, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13974

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR:

  • uses baseURL when pushing with universal router (fixing an unreported error)
  • uses baseURL when sending a redirect

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels May 11, 2022
@danielroe danielroe requested a review from pi0 May 11, 2022 12:18
@danielroe danielroe self-assigned this May 11, 2022
@netlify
Copy link

netlify bot commented May 11, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit abafc75
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/627bacfccfc37100090dacbc

@pi0 pi0 merged commit cad4edd into main May 11, 2022
@pi0 pi0 deleted the fix/redirect-baseurl branch May 11, 2022 17:33
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

navigateTo doesn't respect baseUrl.
2 participants