Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): transform extends layers within node_modules #5042

Merged
merged 11 commits into from
Jun 10, 2022
Merged

fix(nuxt): transform extends layers within node_modules #5042

merged 11 commits into from
Jun 10, 2022

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 18, 2022 •
edited

🔗 Linked issue

resolves nuxt/nuxt#13996

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds support for auto-imports within extends layers, as well as adding them to build.transpile. Incidentally, it also fixes a nasty bug with webpack where we weren't respecting build.transpile (I may extract the latter to a separate PR if this PR needs more attention).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels May 18, 2022
@danielroe danielroe requested a review from pi0 May 18, 2022 15:02
@danielroe danielroe self-assigned this May 18, 2022
@netlify
Copy link

netlify bot commented May 18, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 5f7ddd2
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62a344b82592f00009b2aa0b

@danielroe danielroe mentioned this pull request May 18, 2022
Merged
7 tasks
pi0
pi0 reviewed May 20, 2022
View reviewed changes
packages/webpack/src/presets/nuxt.ts Outdated Show resolved Hide resolved
packages/nuxt/src/core/nuxt.ts Outdated Show resolved Hide resolved
packages/nuxt/src/auto-imports/module.ts Outdated Show resolved Hide resolved
pi0
pi0 reviewed Jun 10, 2022
View reviewed changes
packages/nuxt/src/core/nuxt.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat(nuxt): support auto imports within layers in node_modules fix(nuxt): support auto imports within extend layers in node_modules Jun 10, 2022
@pi0 pi0 changed the title fix(nuxt): support auto imports within extend layers in node_modules fix(nuxt): transform extends layers within node_modules Jun 10, 2022
@pi0
Copy link
Member

pi0 commented Jun 10, 2022

@danielroe Can you please check if we also need this for nitro options to include layers?

@pi0 pi0 merged commit 846be5c into main Jun 10, 2022
@pi0 pi0 deleted the fix/transpile-extends branch June 10, 2022 13:33
This was referenced Jun 10, 2022
Merged
Merged
This was referenced Jun 12, 2022
Merged
Open
@danielroe danielroe added the 3.x label Jan 19, 2023
@john-eos john-eos mentioned this pull request Mar 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x enhancement New feature or request 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support auto-imports when using extends
2 participants
@danielroe @pi0