Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(vite): check types with vue-tsc #6012

Merged
merged 2 commits into from
Jul 20, 2022
Merged

feat(vite): check types with vue-tsc #6012

merged 2 commits into from
Jul 20, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14336

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This uses the new vueTsc option of vite typechecker plugin which enables checking vue files πŸ™Œ

... and tells users they need to install dependencies for this to work.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working vite πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 20, 2022
@danielroe danielroe requested a review from pi0 July 20, 2022 11:57
@danielroe danielroe self-assigned this Jul 20, 2022
@netlify
Copy link

netlify bot commented Jul 20, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 64b46bd
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d7edc5d1e587000a6873b8
😎 Deploy Preview https://deploy-preview-6012--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title fix(vite): check types with vue-tsc feat(vite): check types with vue-tsc Jul 20, 2022
@pi0 pi0 merged commit edbe4fe into main Jul 20, 2022
@pi0 pi0 deleted the fix/typecheck branch July 20, 2022 15:15
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage vite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typeCheck: true does nothing
2 participants