Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit): resolve aliases in plugin src #6037

Merged
merged 1 commit into from Jul 21, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14299

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The test in

return Boolean(app?.plugins.find(i => i.src === id) || app.middleware.find(m => m.path === id))
relies on an absolute path. It probably makes sense to resolve plugin paths to absolute when normalizing though, and this resolves the other issue too.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working kit πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 21, 2022
@danielroe danielroe requested a review from pi0 July 21, 2022 13:55
@danielroe danielroe self-assigned this Jul 21, 2022
@netlify
Copy link

netlify bot commented Jul 21, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 86923dc
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d95ae056933a000899810c

@pi0 pi0 merged commit 4d80c43 into main Jul 21, 2022
@pi0 pi0 deleted the fix/normalize-plugin-paths branch July 21, 2022 14:05
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working kit πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async plugins not working correctly when registered via nuxt.config
2 participants