This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(schema): exclude functions from DeepPartial
#6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
types
🔨 p3-minor-bug
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Jul 27, 2022
| @@ -13,7 +13,7 @@ export default { | |||
| * Properties that will be set directly on `Vue.config` for vue@2. | |||
| * | |||
| * @see [vue@2 Documentation](https://v2.vuejs.org/v2/api/#Global-Config) | |||
| * @type {import('vue/types/vue').VueConfiguration} | |||
| * @type {typeof import('vue/types/vue').VueConfiguration} | |||
There was a problem hiding this comment.
Does it makes sense to automatically infer this in untyped?
There was a problem hiding this comment.
The issue is that we have a two stage build here.
There was a problem hiding this comment.
Sure. I mean if untyped can add automatically add typeof prefix to import in @type annotations.
There was a problem hiding this comment.
(anyway, this fix makes sense. Was thinking of a way to avoid future issues like this)
pi0
approved these changes
Jul 27, 2022
danielroe
changed the title
DeepPartial
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14162
❓ Type of change
📚 Description
An early return for functions solves some issues with functional types (including missing types for
hook, for example). There were also a couple of incorrect types in_app.📝 Checklist