Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): extract component to provide route #6325

Merged
merged 2 commits into from Aug 3, 2022
Merged

fix(nuxt): extract component to provide route #6325

merged 2 commits into from Aug 3, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves nuxt/nuxt#14475

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fixes a regression where we always rerender route components.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working pages ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Aug 3, 2022
@danielroe danielroe requested a review from pi0 August 3, 2022 10:10
@danielroe danielroe self-assigned this Aug 3, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022 •
edited

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 7774546
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ea4dd9075f6a0009f4ba68

@danielroe danielroe changed the title fix(nuxt): provide route inline fix(nuxt): extract component to provide route Aug 3, 2022
pi0
pi0 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally trying behavior of last commit seems 👍🏼

@pi0 pi0 merged commit f75d0df into main Aug 3, 2022
@pi0 pi0 deleted the fix/suspense-with-keys branch August 3, 2022 10:38
@pi0 pi0 mentioned this pull request Aug 5, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

edge version is triggering re-renders on nested pages
2 participants
@danielroe @pi0