Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): better equality check for json cookies #6352

Merged
merged 3 commits into from
Aug 4, 2022
Merged

fix(nuxt): better equality check for json cookies #6352

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa36d5
fix(nuxt): add basic equality checking for json cookies
danielroe Aug 4, 2022
fecb85e
feat: use `ohash` to check deep equality
danielroe Aug 4, 2022
c581552
Merge branch 'main' into fix/equal-cookie-object
pi0 Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/nuxt/src/app/composables/cookie.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { parse, serialize, CookieParseOptions, CookieSerializeOptions } from 'co
import { appendHeader } from 'h3'
import type { CompatibilityEvent } from 'h3'
import destr from 'destr'
import { isEqual } from 'ohash'
import { useRequestEvent } from './ssr'
import { wrapInRef } from './utils'
import { useNuxtApp } from '#app'
Expand Down Expand Up @@ -34,7 +35,7 @@ export function useCookie <T=string> (name: string, _opts?: CookieOptions<T>): C
} else if (process.server) {
const nuxtApp = useNuxtApp()
const writeFinalCookieValue = () => {
if (cookie.value !== cookies[name]) {
if (!isEqual(cookie.value, cookies[name])) {
writeServerCookie(useRequestEvent(nuxtApp), name, cookie.value, opts)
}
}
Expand Down