This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
refactor(nuxt): use relative imports into composables #7487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
I came a significant performance hit (in Nuxt Bridge) from importing from
#app
alias with vite, because#app
re-exports lots of files which themselves import from#app
.We can work around that by using relative imports, which I think is also slightly nicer. Even though I haven't measured a slow-down in this repo, it can't hurt and should be a more intelligible approach for vite. I've left a number of imports from
#app
untouched within plugins/components as these are not re-exported from#app
. (It might also be possible to do the same withhead
, but it's still in a quasi-independent state and this can wait for improvements to its implementation.π Checklist