Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support modifiers prop for components #154

Merged
merged 3 commits into from
Jan 25, 2021
Merged

feat: support modifiers prop for components #154

merged 3 commits into from
Jan 25, 2021

Conversation

flozero
Copy link
Contributor

@flozero flozero commented Jan 22, 2021

I have a concern about modifiers.

Every providers can have really differents modifiers from one to another. Would not be better to have like:

  • Each provider receive one option(s) object where are define all available modifiers
  • He is doing its own check / test
  • So with that you can delete the default one.

I know it will not be like on props for fit etc but one object. In my opinion It will be clearer and more modular.

What do you think ?

@pi0 what do you think?

@pi0 pi0 changed the title feat: adding back the options property feat: support custom modifiers for components Jan 22, 2021
@pi0 pi0 changed the title feat: support custom modifiers for components feat: support custom modifiers prop for components Jan 22, 2021
@pi0 pi0 changed the title feat: support custom modifiers prop for components feat: support modifiers prop for components Jan 22, 2021
@flozero flozero requested a review from pi0 January 22, 2021 17:07
@pi0 pi0 merged commit 6fe9e8f into nuxt:dev Jan 25, 2021
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants