fix(vercel): fix vercel auto-detection and provide local vercel mode #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Apr 29, 2021
danielroe
changed the title
vercel environment
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 62.25% 62.27% +0.02%
==========================================
Files 23 23
Lines 559 562 +3
Branches 162 162
==========================================
+ Hits 348 350 +2
- Misses 211 212 +1
Continue to review full report at Codecov.
|
pi0
reviewed
Apr 30, 2021
danielroe
changed the title
vercel environment
pi0
reviewed
Apr 30, 2021
pi0
approved these changes
May 3, 2021
This was referenced May 5, 2021
procrates
pushed a commit
to procrates/nuxt-image
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes vercel auto-detection (note the issue was only with older deployments that didn't have system environment variables exposed to the build).
In addition, if
vercelprovider is manually selected, in development@nuxt/imagewill provide warnings if un-configured widths are used (or if no width is set manually) to prevent issues in deployment. As@nuxt/imageis transpiled, this will be tree-shaken out in build.