feat(runtime): catch image exceptions and prevent page crash #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Oct 19, 2020
pi0
reviewed
Oct 19, 2020
pi0
approved these changes
Oct 19, 2020
procrates
pushed a commit
to procrates/nuxt-image
that referenced
this pull request
Feb 21, 2023
* feat(runtime): catch image exceptions and prevent global crash * fix: unify error handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing wrong with
nuxt-imageshould not lead page crash. When the user uses an invalid provider or preset Image module throw an exception, We need to catch these exceptions to prevent page crash.Instead we can show the exception message inside
nuxt-image.