Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: warn about <NuxtPicture> not supporting different image sources #1326

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

Lehoczky
Copy link
Contributor

@Lehoczky Lehoczky commented Apr 14, 2024

Related issue: #309

This is a very crucial missing feature, that can bite people later on if they expect the NuxtPicture component to be a drop-in replacement of the native picture element. The warning will help others to find solutions for using multiple image source in the linked issue thread.

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.68%. Comparing base (8701991) to head (4fae021).
Report is 50 commits behind head on main.

❗ Current head 4fae021 differs from pull request most recent head f38bee7. Consider uploading reports for the commit f38bee7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   68.20%   59.68%   -8.52%     
==========================================
  Files          76       78       +2     
  Lines        4299     5073     +774     
  Branches      397      407      +10     
==========================================
+ Hits         2932     3028      +96     
- Misses       1339     2015     +676     
- Partials       28       30       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@danielroe danielroe merged commit d8e14ed into nuxt:main Apr 22, 2024
1 check failed
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants