Add high density display support #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? We really need a way to support 2x and 3x in this package! |
|
I was well on my way integrating this plugin, noticed the quality issue on my 4k 24" monitor and am now removing it. Will be back when high density is supported. |
leonardo-koslowski
approved these changes
Jun 2, 2022
|
Any updates on this? |
|
why was this closed? we still seem to be missing hidpi display support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, when you specify a size of 320 pixels, it will only generate an image with a size of 320px. But most smartphones have higher density displays, so we also need to add 640px (x2) and 960px (x3) to the srcset attribute (not in the sizes attribute). Adding those sizes to the currently available 'sizes' options, is not a possibility since that will also include it in the sizes attribute (which is not allowed, since that would generate incorrect media conditions)