Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep internal provider enable #60

Merged
merged 4 commits into from
Nov 7, 2020
Merged

feat: keep internal provider enable #60

merged 4 commits into from
Nov 7, 2020

Conversation

farnabaz
Copy link
Member

  • Always keep internal provider available
  • Create ipx option inside image module options to control behavior of ipx
  • Rename local provider to ipx and warn if users define a provider with name ipx
  • Update docs

close #57

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #60 into master will decrease coverage by 0.12%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   70.69%   70.56%   -0.13%     
==========================================
  Files          21       21              
  Lines         546      547       +1     
  Branches      129      130       +1     
==========================================
  Hits          386      386              
- Misses        158      159       +1     
  Partials        2        2              
Impacted Files Coverage Δ
src/providers/ipx/index.ts 100.00% <ø> (ø)
src/providers/ipx/runtime.ts 100.00% <ø> (ø)
src/index.ts 83.95% <75.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b62a5...e4e1dea. Read the comment docs.

@farnabaz farnabaz merged commit 349b40a into master Nov 7, 2020
@farnabaz farnabaz deleted the provider-dx branch November 7, 2020 07:22
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Provider DX
3 participants