Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not inject $img by default #836

Merged
merged 8 commits into from
Jun 6, 2023
Merged

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe self-assigned this May 29, 2023
@nuxt-studio
Copy link

nuxt-studio bot commented May 29, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 8ba2093

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for nuxt-image-v1 ready!

Name Link
🔨 Latest commit 8ba2093
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/647f34198702a20008d522ab
😎 Deploy Preview https://deploy-preview-836--nuxt-image-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe mentioned this pull request May 29, 2023
@danielroe danielroe requested a review from pi0 May 29, 2023 13:48
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have added a (dev only) placeholder to instruct users about migration since this is a fairly common feature and many are probably using it...

@danielroe danielroe merged commit c0f3b00 into main Jun 6, 2023
6 checks passed
@danielroe danielroe deleted the perf/composable-image branch June 6, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants