Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix example package.json #192

Merged
merged 3 commits into from
Nov 22, 2023
Merged

chore: fix example package.json #192

merged 3 commits into from
Nov 22, 2023

Conversation

danielroe
Copy link
Member

This is a preliminary test towards updating default module packaging in https://github.com/nuxt/starter.

@danielroe danielroe self-assigned this Nov 16, 2023
@userquin
Copy link
Member

userquin commented Nov 16, 2023 •
edited
Loading

types.d.ts and types.d.mts should use ./module.js in both imports

danielroe
danielroe commented Nov 22, 2023
View reviewed changes
test/build.spec.ts Outdated Show resolved Hide resolved
danielroe
danielroe commented Nov 22, 2023
View reviewed changes
src/commands/build.ts Outdated Show resolved Hide resolved
danielroe
danielroe commented Nov 22, 2023
View reviewed changes
src/commands/build.ts Outdated Show resolved Hide resolved
danielroe
danielroe commented Nov 22, 2023
View reviewed changes
test/build.spec.ts Outdated Show resolved Hide resolved
@danielroe danielroe marked this pull request as ready for review November 22, 2023 12:32
@danielroe danielroe merged commit bf50e93 into main Nov 22, 2023
1 check passed
@danielroe danielroe deleted the fix/dts branch November 22, 2023 12:35
@Denoder Denoder mentioned this pull request May 18, 2024
Open
@Denoder Denoder mentioned this pull request Jun 13, 2024
Open
@Denoder Denoder mentioned this pull request Jul 3, 2024
Open
@Denoder Denoder mentioned this pull request Jul 11, 2024
Open
@Denoder Denoder mentioned this pull request Jul 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@userquin userquin Awaiting requested review from userquin

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielroe @userquin