Skip to content

Commit

Permalink
chore: mark jsdom as external to remove warning
Browse files Browse the repository at this point in the history
  • Loading branch information
pi0 committed Feb 6, 2020
1 parent 1df1874 commit 39d3368
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
5 changes: 4 additions & 1 deletion packages/server/package.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
export default {
build: true
build: true,
rollup: {
externals: ['jsdom']
}
}
3 changes: 2 additions & 1 deletion scripts/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ export default class Package {
const config = {
rootDir: this.options.rootDir,
alias: {},
replace: {}
replace: {},
...this.options.rollup
}

// Replace linkedDependencies with their suffixed version
Expand Down
5 changes: 4 additions & 1 deletion scripts/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export default function rollupConfig ({
input = 'src/index.js',
replace = {},
alias = {},
externals = [],
resolve = {
only: [
/lodash/
Expand All @@ -43,7 +44,9 @@ export default function rollupConfig ({
// Dependencies that will be installed alongise with the nuxt package
...Object.keys(pkg.dependencies || {}),
// Builtin node modules
...builtins
...builtins,
// Explicit externals
...externals
],
plugins: [
aliasPlugin(alias),
Expand Down

0 comments on commit 39d3368

Please sign in to comment.