New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context.isClient and context.isServer deprecation warnings when not used #2527

Closed
joealden opened this Issue Jan 8, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@joealden

joealden commented Jan 8, 2018

I have just upgrade nuxt to 1.0.0 in one of my projects and I am getting the following warnings every time a page is server side rendered (Both in the server console and on the client):

context.isClient has been deprecated, please use process.client instead.
context.isServer has been deprecated, please use process.server instead.

From my understanding from these release notes,
(https://github.com/nuxt/nuxt.js/releases/tag/v1.0.0) I can still use the context.isClient property inside build.extend(), as this is said:

We also deprecated dev property inside build.extend() in flavour of isDev.

(Little side note, this should say 'in favour' instead of 'in flavour')

If what I think is correct, then I am not using these deprecated APIs in my code, but the warning as still appearing.

Could these warnings maybe be coming from a nuxt module that is still using the deprecated API? (Like what happens when a package you depend on is not using babel-present-env)

This question is available on Nuxt.js community (#c2195)
@joealden

This comment has been minimized.

Show comment
Hide comment
@joealden

joealden Jan 8, 2018

I forgot to add, this is the repo of the codebase: https://github.com/joealden/corum

joealden commented Jan 8, 2018

I forgot to add, this is the repo of the codebase: https://github.com/joealden/corum

@Evild67

This comment has been minimized.

Show comment
Hide comment
@Evild67

Evild67 Jan 8, 2018

Update your nuxt/apollo package to 3.0.1 :) ! Deprecation fix was just merged

Evild67 commented Jan 8, 2018

Update your nuxt/apollo package to 3.0.1 :) ! Deprecation fix was just merged

@dohomi

This comment has been minimized.

Show comment
Hide comment
@dohomi

dohomi Jan 8, 2018

true :-)

dohomi commented Jan 8, 2018

true :-)

@gangsthub

This comment has been minimized.

Show comment
Hide comment
@joealden

This comment has been minimized.

Show comment
Hide comment
@joealden

joealden Jan 8, 2018

@Evild67 Thanks! That has fixed it!

joealden commented Jan 8, 2018

@Evild67 Thanks! That has fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment