Loader completes prematurely if middleware returns a redirect

[silverbackdan]

It appears that if I return a redirect from router middleware, the loader completes, instead of continuing while the page that is being redirected to loads and that routes middleware are executed.

Please let me know if you'd like a repro. Cheers.

_{This question is available on Nuxt.js community (#c2228)}

[clarkdo]

It should be a expected behavior in vue-router, if you have nested router.push, the current and to is same route, routing will be ignored.

So if middleware is redirect('/'), when you access '/about', it will execute the middleware twice:

export default function ({ redirect, route }) {
  console.log(route.fullPath)
  redirect('/')
}

Printed two lines: / and /about

If your behavior is not same like above, could you please provide a repo can reproduce the issue?

[silverbackdan]

Thanks for the fast response @clarkdo

I think I may not have explained well or have misunderstood the answer.

The middleware is executed twice, that's all fine. The issue is the loading bar. It stops after the first request and does not start again. So once the middleware calls redirect, the default loading bar finishes instead of starting again for the redirected route.

[Atinux]

Hi @silverbackdan

I just pushed a fix about it (e33d502), we will release a new version of Nuxt.js next week.

It also handle when a redirect is to himself or to another page :)

[silverbackdan]

That's awesome, thanks @Atinux - you rock!

[Atinux]

@silverbackdan I just pushed v1.1.0 :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.