Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move config files to @nuxt/config #4212

Merged
merged 12 commits into from Oct 27, 2018
Merged

refactor: move config files to @nuxt/config #4212

merged 12 commits into from Oct 27, 2018

Conversation

galvez
Copy link

@galvez galvez commented Oct 27, 2018

Following #4208 and recent discussion in #core.

@galvez galvez added the WIP label Oct 27, 2018
@pi0
Copy link
Member

pi0 commented Oct 27, 2018

@galvez As we may also move some config related utils into this package, what's your idea to keep configs in a sub-directory of packages/config/src ? like src/config or src/nuxt.config?

@galvez
Copy link
Author

galvez commented Oct 27, 2018

@pi0 yeah, I rearranged things a bit now, we had the same thought :) Still WIP

@galvez
Copy link
Author

galvez commented Oct 27, 2018

@pi0 how do I generate the dist dir for a new package?

@pi0
Copy link
Member

pi0 commented Oct 27, 2018

@galvez yarn build ;)

@galvez
Copy link
Author

galvez commented Oct 27, 2018

@pi0 instantly realized that heh

@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #4212 into dev will decrease coverage by 1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4212      +/-   ##
==========================================
- Coverage   88.83%   87.83%   -1.01%     
==========================================
  Files          42       43       +1     
  Lines        1684     1701      +17     
  Branches      436      435       -1     
==========================================
- Hits         1496     1494       -2     
- Misses        161      180      +19     
  Partials       27       27
Impacted Files Coverage Δ
packages/core/src/renderer.js 100% <ø> (ø) ⬆️
packages/config/src/config/build.js 0% <ø> (ø)
packages/config/src/config/server.js 0% <ø> (ø)
packages/config/src/config/index.js 0% <ø> (ø)
packages/common/src/options.js 86.23% <ø> (ø) ⬆️
packages/config/src/config/render.js 0% <ø> (ø)
packages/cli/src/utils.js 83.72% <0%> (ø) ⬆️
packages/config/src/index.js 0% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7794c...f0681b3. Read the comment docs.

@galvez galvez removed the WIP label Oct 27, 2018
@pi0 pi0 merged commit 007ca05 into dev Oct 27, 2018
@pi0 pi0 deleted the refactor/config-package branch October 27, 2018 20:28
@lock
Copy link

lock bot commented Nov 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 26, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants