Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuxt generate comment handling #4458

Closed
jochouen opened this issue Nov 30, 2018 · 3 comments · Fixed by vuejs/vue#9128
Closed

nuxt generate comment handling #4458

jochouen opened this issue Nov 30, 2018 · 3 comments · Fixed by vuejs/vue#9128
Labels
2.x pending triage pending stale

Comments

@jochouen
Copy link

jochouen commented Nov 30, 2018 •
edited

Version

v2.3.2

Reproduction link

https://nuxtjs.org

Steps to reproduce

minify: {
    removeComments: false;
}

 terser: {
  extractComments: false
 },
  1. Write a comment on the page
  2. Yarn generate
  3. The comment was deleted

What is expected ?

test.vue

<template>
  <div>
    <!-- comment -->
    <h1>test</h1>
  </div>
</template>

test.html

<body data-n-head="">
    <div data-server-rendered="true" id="__nuxt__">
      ...      
     <!-- comment -->
     ...
  </body>

What is actually happening?

test.html

<body data-n-head="">
    <div data-server-rendered="true" id="__nuxt__">
      ...      
     <!---->
     ...
  </body>

The comment was deleted

This bug report is available on Nuxt community (#c8251)
@ghost ghost added the cmty:bug-report label Nov 30, 2018
@clarkdo clarkdo mentioned this issue Nov 30, 2018
Merged
13 tasks
@curtisbelt
Copy link

@manniL Any manual intervention someone can do to make this work? A 3rd party integration a client needs actually requires HTML comments for it to work. Thanks!

@manniL
Copy link
Member

manniL commented Jan 27, 2019

@curtisbelt This could probably already work with the latest Vue version.

@stale
Copy link

stale bot commented Apr 20, 2019

Thanks for your contribution to Nuxt.js!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of nuxt-edge
  2. Comment the steps to reproduce it

Issues that are labeled as 🕐Pending will not be automatically marked as stale.

@stale stale bot added the stale label Apr 20, 2019
@stale stale bot closed this as completed Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x pending triage pending stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ssr): renderToString cannot render comment clarkdo/vue
4 participants
@manniL @curtisbelt @jochouen @danielroe