Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build.crossorgin #4472

Merged
merged 2 commits into from Dec 5, 2018
Merged

feat: add build.crossorgin #4472

merged 2 commits into from Dec 5, 2018

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Dec 2, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from aldarund and pi0 December 2, 2018 17:59
@codecov-io
Copy link

codecov-io commented Dec 2, 2018

Codecov Report

Merging #4472 into dev will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4472      +/-   ##
==========================================
+ Coverage   91.36%   91.43%   +0.07%     
==========================================
  Files          60       61       +1     
  Lines        2108     2126      +18     
  Branches      508      516       +8     
==========================================
+ Hits         1926     1944      +18     
  Misses        167      167              
  Partials       15       15
Impacted Files Coverage Δ
packages/config/src/config/build.js 85.71% <ø> (ø) ⬆️
packages/webpack/src/config/client.js 97.22% <100%> (+0.16%) ⬆️
packages/vue-renderer/src/renderer.js 95.95% <100%> (+0.09%) ⬆️
packages/server/src/middleware/nuxt.js 98.63% <100%> (+0.05%) ⬆️
packages/webpack/src/plugins/vue/cors.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c15c18...7595954. Read the comment docs.

@clarkdo clarkdo changed the title fest: add build.corssorgin feat: add build.corssorgin Dec 2, 2018
@manniL manniL changed the title feat: add build.corssorgin feat: add build.crossorgin Dec 2, 2018
@pi0 pi0 merged commit e6808c5 into nuxt:dev Dec 5, 2018
@lock
Copy link

lock bot commented Jan 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2019
@clarkdo clarkdo deleted the cors branch April 2, 2019 13:05
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants