-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor file watchers (chokidar/linux workaround) #4950
Conversation
@pimlie Would you please fix the CI? |
…/pimlie/nuxt.js into fix-chokidar-workaround-refactor
Codecov Report
@@ Coverage Diff @@
## dev #4950 +/- ##
==========================================
+ Coverage 92.78% 92.87% +0.09%
==========================================
Files 73 73
Lines 2426 2429 +3
Branches 596 596
==========================================
+ Hits 2251 2256 +5
+ Misses 160 158 -2
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor 💚
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types of changes
Description
When the previous pr (#4717) got merged pi0 commented 'For experiment' (i think we discussed it on discord as well), but since that code actually got released in 2.4 its time to refactor/cleanup it a bit so (mainly) the
files
watcher also benefit from the workaround.I'd prefer to move the
createFileWatcher
method from the Builder class to some util file (and pass this.options.watchers as an argument), but I was not sure what the best place would be. A util file in the builder package or a filewatcher file in util package? Or just keep it as a class member?(I will fix the tests once the above has been discussed)
Checklist: