New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coffeescript Vuex silently stop working on 2.5.1 #5423
Comments
I would also note that if I enable module store in the coffeescript example by adding a file /store/module.coffee
and try to reference it in pages/index.vue
with Nuxt 2.5.1+ I get
|
It appears to have broken a little earlier than reported above, I see it broken in 2.5.0. And is still an issue in 2.6.3. |
I've been digging into the code and I'm not use exactly where it broke, but I've found changing resolveFiles() to this: async resolveFiles(dir, cwd = this.options.srcDir) {
const extensions = this.supportedExtensions.concat(this.nuxt.options.extensions)
return this.ignore.filter(await glob(`${dir}/**/*.{${extensions.join(',')}}`, {
cwd,
ignore: this.options.ignore
}))
} fixes the issue; the coffeescript store module gets found. What I'm doing is concat-ing the The above is a clunky solve not worthy of a PR, but should point out the problem is that |
I have a workaround that I published to my CoffeesScript Nuxt module package: BKWLD/nuxt-coffeescript-module@143656e. This fixes this VueX issue for me but doesn't fix the issue with CoffeeScript local modules #5087 |
@weotch |
WORKS PERFECTLY FINE ! definitely need to add this two lines of code into master branch as fast as possible! |
workaround is working like a charm too! |
Feel free to create a PR for the example to make it work too, or even to the core |
I wasn't sure if my workaround should be the right solve for this ... like, ideally, I feel like Nuxt should use the |
@manniL hey did you fixed coffeescript linter issue of your CI ? |
Version
v2.5.1
Reproduction link
https://github.com/nuxt/nuxt.js/tree/dev/examples/coffeescript
Steps to reproduce
Build project with
"nuxt": "2.5.1"
What is expected ?
Vuex that works with Coffeescript, just like on 2.4.5
What is actually happening?
Nothing.
The text was updated successfully, but these errors were encountered: