Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when building failed in quiet mode #6075

Merged
merged 3 commits into from Jul 17, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 16, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #5623

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 July 16, 2019 18:51
@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #6075 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6075      +/-   ##
==========================================
- Coverage   95.69%   95.65%   -0.04%     
==========================================
  Files          82       82              
  Lines        2694     2695       +1     
  Branches      693      693              
==========================================
  Hits         2578     2578              
- Misses         98       99       +1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.09% <0%> (-0.02%) ⬇️
#unit 92.8% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/webpack/src/builder.js 92.55% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f10f40...b2d5023. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt build no throw error when process.env.CI = true
4 participants